Support Lenovo laptop with rt722 and rt1320#5692
Open
oortcomet wants to merge 3 commits intothesofproject:topic/sof-devfrom
Open
Support Lenovo laptop with rt722 and rt1320#5692oortcomet wants to merge 3 commits intothesofproject:topic/sof-devfrom
oortcomet wants to merge 3 commits intothesofproject:topic/sof-devfrom
Conversation
…bles Use functional topologies to support RT722 topologies with/without amplifiers, e.g. sof-ptl-rt722.tplg, sof-ptl-rt722-rt1320.tplg... If these entries are not removed, they will find the first same link of sof-ptl-rt722.tplg. Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Add 'rt1320-aif2' dai info for rt1320 dmic function. Signed-off-by: Derek Fang <derek.fang@realtek.com>
The Lenovo T14s Gen 7 system uses rt722 UAJ on link3 and rt1320 amp and dmic on link2. This patch supports the combination. Signed-off-by: Derek Fang <derek.fang@realtek.com>
oortcomet
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
Collaborator
|
Can one of the admins verify this patch?
|
bardliao
reviewed
Mar 12, 2026
| card->components = devm_kasprintf(card->dev, GFP_KERNEL, | ||
| "%s mic:%s", card->components, | ||
| mic_name); | ||
| if (rt1320_dmic_num > 0) |
Collaborator
There was a problem hiding this comment.
What if dai->name == rt1320-aif2 but rt1320_dmic_num == 0?
Author
There was a problem hiding this comment.
The situation you said should never have happened.
Might use
if (!strcmp(dai->name, "rt1320-aif2"))
instead of
if (rt1320_dmic_num > 0)
Collaborator
|
test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits support the combination with rt722 and rt1320 soundwire devices.