Skip to content

src: cosmetic: simplify an invalid configuration check #10626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyakh wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

src: cosmetic: simplify an invalid configuration check #10626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/audio/src/src_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,12 +523,12 @@ int src_params_general(struct processing_module *mod,
* be aligned to 8 bytes as required by some Xtensa
* instructions (e.g AE_L32X2F24_XC)
*/
delay_lines_size = ALIGN_UP(sizeof(int32_t) * cd->param.total, 8);
if (delay_lines_size == 0) {
comp_err(dev, "delay_lines_size = 0");
if (cd->param.total == 0) {
comp_err(dev, "configuration failed: delay_lines_size = 0");

return -EINVAL;
}
delay_lines_size = ALIGN_UP(sizeof(int32_t) * cd->param.total, 8);

Comment on lines +526 to 532
/* free any existing delay lines. TODO reuse if same size */
mod_free(mod, cd->delay_lines);
Expand Down
Loading