[CORE-12314] Use two ServiceEndpoint instances for host-network and pod-network#4474
Merged
coutinhop merged 1 commit intotigera:masterfrom Mar 17, 2026
Merged
Conversation
coutinhop
force-pushed
the
pedro-CORE-12314
branch
from
445c75d to
a24a266
Compare
caseydavenport
requested changes
Mar 6, 2026
coutinhop
force-pushed
the
pedro-CORE-12314
branch
from
a24a266 to
d084fb3
Compare
coutinhop
changed the title
…od-network Use two separate ServiceEndpoint instances (Endpoint and PodNetworkEndpoint) instead of a single struct, to distinguish between host-network and pod-network K8s API server endpoints. Simplify EnvVars() by removing hostNetworked/provider params — callers pick the appropriate instance. Remove Docker EE proxy.local special-case, which is now handled implicitly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
coutinhop
force-pushed
the
pedro-CORE-12314
branch
from
d084fb3 to
a747635
Compare
caseydavenport
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use two separate ServiceEndpoint instances (Endpoint and PodNetworkEndpoint)
instead of a single struct, to distinguish between host-network and pod-network
K8s API server endpoints. Simplify EnvVars() by removing hostNetworked/provider
params — callers pick the appropriate instance. Remove Docker EE proxy.local
special-case, which is now handled implicitly.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.