This repository was archived by the owner on Jan 18, 2024. It is now read-only.
[timescaledb-single] Add tolerations to patroni config update job#307
Open
Art3mK wants to merge 2 commits intotimescale:mainfrom
Open
[timescaledb-single] Add tolerations to patroni config update job#307Art3mK wants to merge 2 commits intotimescale:mainfrom
Art3mK wants to merge 2 commits intotimescale:mainfrom
Conversation
|
|
Author
|
sorry, but bump! |
agronholm
reviewed
Sep 10, 2022
| name: timescaledb-single | ||
| description: 'TimescaleDB HA Deployment.' | ||
| version: 0.10.0 | ||
| version: 0.10.1 |
Contributor
There was a problem hiding this comment.
Why are you trying to update the chart version? This is up to the maintainers.
Contributor
There was a problem hiding this comment.
This is not. We require chart update on each PR as mentioned in contributing doc - https://github.com/timescale/helm-charts/blob/main/CONTRIBUTING.md#technical-requirements
agronholm
reviewed
Sep 10, 2022
Comment on lines
+40
to
+43
| {{- with .Values.tolerations }} | ||
| tolerations: | ||
| {{ toYaml . | indent 8 }} | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
Suggested change
| {{- with .Values.tolerations }} | |
| tolerations: | |
| {{ toYaml . | indent 8 }} | |
| {{- end }} | |
| tolerations: | |
| {{ toYaml .Values.tolerations | nindent 8 }} |
Contributor
There was a problem hiding this comment.
Now that I think about it, what happens when the list is empty? Shouldn't this block be guarded against that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will use tolerations set for the STS to allow job pod to be scheduled on tainted nodes, in my case there is cluster, where all nodes are tainted in some way, so no tolerations on job pod will prevent its scheduling.