Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ) | ||
| const isRestricted = isRestrictedBase || failedScan || !cannotDownloadSubmission | ||
| const isOwnSubmission = String(submission.memberId) === String(loginUserInfo?.userId) | ||
| const canDownloadSubmission = canDownloadSubmissionFromSubmissionsTab({ |
There was a problem hiding this comment.
[💡 readability]
The isOwnSubmission variable is used to determine if the submission belongs to the current user. Consider using a more descriptive name like isUserSubmission to improve clarity.
| const isRestricted = isRestrictedBase || failedScan || !cannotDownloadSubmission | ||
| const isOwnSubmission = String(submission.memberId) === String(loginUserInfo?.userId) | ||
| const canDownloadSubmission = canDownloadSubmissionFromSubmissionsTab({ | ||
| canViewSubmissions, |
There was a problem hiding this comment.
[maintainability]
The function canDownloadSubmissionFromSubmissionsTab is used to determine download permissions. Ensure that this function handles all necessary permission checks, especially if new roles or conditions are added in the future.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix broken submission visibility logic
https://topcoder.atlassian.net/browse/PM-4281