Remove React from static scripts, fix Prask task accordingly by kubik369 · Pull Request #1118 · trojsten/web

kubik369 · 2018-01-21T23:43:41Z

Neviem ako testnúť tú Prask úlohu na stránke, rady sú vítané.

codecov · 2018-01-21T23:47:12Z

Codecov Report

Merging #1118 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1118   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files         162      162           
  Lines        6969     6969           
=======================================
  Hits         5635     5635           
  Misses       1334     1334

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7c2e2...93912eb. Read the comment docs.

kubik369 · 2018-01-22T06:59:22Z

Všimol som si, že React používa ešte nejaký Tip of the day. Nebudem klamať, nikdy som si nič také nevšimol na stránke a je to momentálne prázdny element na vrchu noviniek. Plánuje sa s tým niečo robiť? Ak hej, hodilo by sa urobiť v tom django_tips opäť jeden bundle, v ktorom by ten relevantný React bol, nech sa to všade neloaduje. Ak nie, tak to celé odstrániť najskôr.

mhozza · 2018-01-22T09:33:47Z

To funguje. Je to dynamické, preto je ten element prázdny.

…

On Mon, 22 Jan 2018, 06:59 Jakub Šimo, ***@***.***> wrote: Všimol som si, že React používa ešte nejaký Tip of the day. Nebudem klamať, nikdy som si nič také nevšimol na stránke a je to momentálne prázdny element na vrchu noviniek. Plánuje sa s tým niečo robiť? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1118 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABH4NzkO0NznzNroCFhAGIpRQ3ZGR3oLks5tNDHKgaJpZM4RmBb0> .

kubik369 · 2018-01-22T09:52:43Z

To chápem, že to je dynamické a ten ReactDOM to tam má vyrenderovať, ale nič sa tam nezobrazuje, ani ako pre admina, ani v incognito, usera som neskúšal. A stále platí ten point, že by to malo mať React so sebou v bundli, keďže to je len na jednom mieste.

mhozza · 2018-01-22T09:58:51Z

To preto že si všetko videl. Ale jeden som ti označil ako neprecitany tak by si tam teraz mal niečo vidieť.

…

On Mon, 22 Jan 2018, 09:52 Jakub Šimo, ***@***.***> wrote: To chápem, že to je dynamické a ten ReactDOM to tam má vyrenderovať, ale nič sa tam nezobrazuje, ani ako pre admina, ani v incognito, usera som neskúšal. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1118 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABH4N8od2fWEZUE-s0OSOG4alPhQFg2Fks5tNFprgaJpZM4RmBb0> .

kubik369 · 2018-01-22T10:03:01Z

Ok, makes sense, súhlasíš s tým, že by to malo byť bundlenuté? Ak áno, dám ti PR na django-tips.

mhozza · 2018-01-22T10:03:59Z

Pokojne.

…

On Mon, 22 Jan 2018, 10:03 Jakub Šimo, ***@***.***> wrote: Ok, makes sense, súhlasíš s tým, že by to malo byť bundlenuté? Ak áno, dám ti PR na django-tips. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1118 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABH4Nxh1OeGV--0Iy2DKaQ3d2R1FGF1Wks5tNFzVgaJpZM4RmBb0> .

kubik369 · 2018-01-22T10:04:38Z

Ešte lepšie, ak by sa dalo, že vôbec ten element spolu s tým bundlom nebudú includenuté ak už nemáš tips.

black3r · 2018-01-22T10:22:09Z

trojsten/special/plugin_prask_2_4_1/static/plugin_prask_2_4_1/js/package.json

+{
+  "name": "prask_questions",
+  "version": "1.0.0",
+  "description": "compile by: ``` babel --presets es2015,react --watch src/ --out-dir lib/ ```",


preco je v description napisane nieco, co vyzera uplne odlisne ako commandy v scripts ?

Eh, to je pozostatok z toho čo tam Prefix/Sysel porobili, ušlo mi to.

black3r · 2018-01-22T10:23:45Z

ten prekompilovany subor z prasku sa filenamom tvari ako minifikovany, ale v skutocnosti minifikovany nie je.... nedalo by sa s tym nieco urobit? na rozdiel od toho fontu toto je 1.7MB :D

kubik369 · 2018-01-22T10:28:32Z

@black3r My bad, fixed. Má to 203kb minifikované :)

// EDIT
Update, zabudol som pridať niektoré pluginy, už 138kb.

mhozza · 2018-01-22T21:02:27Z

trojsten/templates/trojsten/layout/base.html

      <![endif]-->
      <!-- IE10 viewport hack for Surface/desktop Windows 8 bug -->
      <script src="{% static "js/ie10-viewport-bug-workaround.js" %}"></script>
-      <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.0.1/react.min.js" type="text/javascript"></script>


Toto teda nepotrebujeme uz?

Nie, je to includenuté v tom js bundle-y. Čo mi pripomína, že možno by som tam mohol popchať všetky tie js veci do toho. Pozriem sa na to v stredu poobede/štvrtok.

black3r · 2018-01-22T21:11:53Z

trojsten/special/plugin_prask_2_4_1/static/plugin_prask_2_4_1/js/webpack.config.js

+    new webpack.DefinePlugin({
+      'process.env.NODE_ENV': debug ? JSON.stringify('development') : JSON.stringify('production')
+    }),
+    new webpack.optimize.ModuleConcatenationPlugin(),


toto aj nieco robi, ked v babel-i nemas nakonfigurovane "modules": false ?

Nie, máš pravdu. Config ešte trochu refine-nem, keď sa mi podarí/niekto mi pomôže s tými django-tips a tu sa môže použiť ten istý prakticky.

Co potrebujes s tymi django-tips?

mhozza · 2018-05-14T22:01:28Z

Toto je v akom stave?

mhozza · 2019-01-28T22:05:04Z

👉 @kubik369

mhozza · 2019-06-15T09:20:08Z

👉 @kubik369

Remove React from static scripts, fix Prask task accordingly

4b2610f

kubik369 added the area-performance label Jan 21, 2018

kubik369 requested review from black3r, mhozza and syslo January 21, 2018 23:45

black3r reviewed Jan 22, 2018

View reviewed changes

Minify Prask javascript

0cf2d54

kubik369 added 2 commits January 22, 2018 12:20

Optimise webpack production config

280bd58

Fix description in package.json

93912eb

mhozza reviewed Jan 22, 2018

View reviewed changes

black3r reviewed Jan 22, 2018

View reviewed changes

Conversation

kubik369 commented Jan 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kubik369 commented Jan 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhozza commented Jan 22, 2018 via email

Uh oh!

kubik369 commented Jan 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhozza commented Jan 22, 2018 via email

Uh oh!

kubik369 commented Jan 22, 2018

Uh oh!

mhozza commented Jan 22, 2018 via email

Uh oh!

kubik369 commented Jan 22, 2018

Uh oh!

black3r Jan 22, 2018

Choose a reason for hiding this comment

Uh oh!

kubik369 Jan 22, 2018

Choose a reason for hiding this comment

Uh oh!

black3r commented Jan 22, 2018

Uh oh!

kubik369 commented Jan 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhozza Jan 22, 2018

Choose a reason for hiding this comment

Uh oh!

kubik369 Jan 22, 2018

Choose a reason for hiding this comment

Uh oh!

black3r Jan 22, 2018

Choose a reason for hiding this comment

Uh oh!

kubik369 Jan 22, 2018

Choose a reason for hiding this comment

Uh oh!

mhozza Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

mhozza commented May 14, 2018

Uh oh!

mhozza commented Jan 28, 2019

Uh oh!

mhozza commented Jun 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kubik369 commented Jan 21, 2018 •

edited

Loading

codecov bot commented Jan 21, 2018 •

edited

Loading

kubik369 commented Jan 22, 2018 •

edited

Loading

kubik369 commented Jan 22, 2018 •

edited

Loading

kubik369 commented Jan 22, 2018 •

edited

Loading