Fix builtins release checkout again#261
Merged
masklinn merged 1 commit intoua-parser:masterfrom Mar 3, 2025
Merged
Conversation
Turns out `'master'` probably worked all along as a fallback, the problem is that I was using `'master '`, with a trailing space, which was not a branch git managed to find for obvious reason, and since I carried the error into the fully qualified reference... is still didn't work. And manual triggers didn't have the issue because the tag was `required`, so I'd have to input the tag by hand every time, and the fallback value would be bypassed. - fix the fallback value - remove the requirement on `tag`, such that it's possible to manually trigger the action in a default state
masklinn
force-pushed
the
fix-builtins-release-checkout-again
branch
from
337d03c to
967a2bb
Compare
Contributor
Author
|
Turns out the issue was between keyboard and chair, when I applied zizmor's recs and converted the text substitution to an env in 9f170aa I added an extra space to the fallback value, and never realised it was there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently it's still not working when scheduled (https://github.com/ua-parser/uap-python/actions/runs/13608604862) even though it works fine when triggered (https://github.com/ua-parser/uap-python/actions/runs/13636193948). The logs are the exact same until the switch fails.