feat: permalink with costing options#396
Open
rohhann12 wants to merge 2 commits intovalhalla:masterfrom
Open
Conversation
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/396 |
rohhann12
changed the title
Contributor
Author
|
hi @nilsnolde let me know if you have any ideas on how we can handle the geo json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes Issue
closes #335
👨💻 Changes proposed
-Added a costing query parameter to the URL that stores any non-default costing options as JSON
📄 Note to reviewers
Only non-default values are sync to keep the URL short. exclude_polygons is intentionally skipped as it can hold large GeoJSON data.
📷 Screenshots