Treat Undercity slime as water

[Stoabrogga]

🍰 Pullrequest

Treat the slime in the Undercity as water, so it won't hurt the players anymore. Don't know if this is the correct way to fix it, but it works.

Related commit:
f54db6b (PR #3118)

Proof

None

Issues

Closes #3246

How2Test

• Extract maps/vmaps
• Swim in the slime in Undercity

Todo / Checklist

None

[Wall-core]

the issue is with the other commit that was added. It fixed the checks for naxxramas slime, but for some reason removed the checks for IsInSlime which excluded undercity slime. the IsInSlime() function should be fixed instead. Slime should not apply environmental damage; instead, it applies a debuff which causes the damage.

[Stoabrogga]

@Wall-core There was no special handling of Undercity, the code parts were commented out:

core/src/game/Objects/Player.cpp

Lines 1038 to 1040 in efa0d8b

	// FIXME: Need to skip slime damage in Undercity, maybe someone can find better way to handle environmental damage
	//if (IsInSlime() && m_zoneUpdateId != 1497)
	// EnvironmentalDamage(DAMAGE_SLIME, urand(sWorld.getConfig(CONFIG_UINT32_ENVIRONMENTAL_DAMAGE_MIN), sWorld.getConfig(CONFIG_UINT32_ENVIRONMENTAL_DAMAGE_MAX)));

But in commit f54db6b the comment was deleted and this was added instead:

core/src/game/Objects/Player.cpp

Lines 1038 to 1039 in f54db6b

	if (IsInSlime())
	EnvironmentalDamage(DAMAGE_SLIME, urand(sWorld.getConfig(CONFIG_UINT32_ENVIRONMENTAL_DAMAGE_MIN), sWorld.getConfig(CONFIG_UINT32_ENVIRONMENTAL_DAMAGE_MAX)));

[Wall-core]

what I'm saying though, is that IsInSlime() shouldn't even exist. There's no slime damage in vanilla that isn't applied through a debuff, as shown in the liquid dbcs. There only exists slime in Undercity and Naxxramas, and Naxxramas slime does not apply environmental damage either. This function should be removed entirely.

[Stoabrogga]

Ok, thanks for the explanation. I'll close this PR and open a new one removing the "IsInSlime" function.