Add build option "ENABLE_CPPTRACE"#3256
Open
Stoabrogga wants to merge 3 commits intovmangos:developmentfrom
Open
Add build option "ENABLE_CPPTRACE"#3256Stoabrogga wants to merge 3 commits intovmangos:developmentfrom
Stoabrogga wants to merge 3 commits intovmangos:developmentfrom
Conversation
0blu
reviewed
Mar 14, 2026
cmake/options.cmake
Outdated
| option(USE_EXTRACTORS "Build extractors" OFF) | ||
| option(USE_REALMMERGE "Build helper tool for merging character databases" OFF) | ||
| option(ENABLE_MAILSENDER "Enables support for sending emails via sendgrid.com (requires libcurl)" OFF) | ||
| option(DISABLE_STACK_TRACE "Disables cpptrace stack tracing if not needed (e.g. if GDB is used)" OFF) |
Collaborator
There was a problem hiding this comment.
Maybe we should call it ENABLE_STACK_TRACE and make it ON by default.
Just to prevent double negation and metal overhead.
Collaborator
There was a problem hiding this comment.
Maybe ENABLE_RUNTIME_STACKTRACE (although a stack trace is usually runtime only)
Collaborator
There was a problem hiding this comment.
Or ENABLE_CPPTRACE_STACKTRACE
Contributor
Author
There was a problem hiding this comment.
Or just ENABLE_CPPTRACE?
Contributor
Author
There was a problem hiding this comment.
I now use ENABLE_CPPTRACE because it is shorter, hope that's ok.
Stoabrogga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Add build option "ENABLE_CPPTRACE". Default is "ON". If off, cpptrace is disabled. This can be useful if it is not needed, e.g. if gdb is used instead. Also speeds up the build process because cpptrace has a dependency to libdwarf which also needs zstd. Both are downloaded during the build process.
Proof
None
Issues
None
How2Test
I used Cmake 3.31.6 on Debian 13:
Todo / Checklist
None