Golub Kahan Bidiagonalization and Corresponding Tests#5
Open
etontackett wants to merge 12 commits intomainfrom
Open
Golub Kahan Bidiagonalization and Corresponding Tests#5etontackett wants to merge 12 commits intomainfrom
etontackett wants to merge 12 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Golub Kahan Bidiagonalization, Givens Rotations, and corresponding tests.
Description
This pull request introduces bidiagonalization.jl, which implements Golub Kahan Bidiagonalization using a sequence of Givens rotations. This implementation includes functions for computing Givens rotations coefficients, applying transformations to the rows and columns, and performing bidiagonalization while accumulating the orthogonal matrices H and K. The algorithm transforms A into an upper bidiagonal form satisfying H^T * A * K = B, and applies the transformations to the constant vector and matrix L. Tests were added to cover rectangular matrices and several basic numerical cases to ensure the implementation behaves correctly. Additional tests were added to verify orthogonality and other structural properties.
Motivation and Context
This change adds the implementation of a direct method for solving ridge regression problems. In ridge regression, we aim to solve the regularized least squares problem. The approach used to solve this is to reduce the A matrix into bidiagonal form by applying right and left orthogonal transformations. Golub Kahan Bidiagonalization is a method used for performing this reduction. Once A is in bidiagonal form, the resulting system becomes much easier to solve and analyze.
Types of changes
Checklists:
Code and Comments
If this PR includes modifications to the code base, please select all that apply.
API Documentation
Manual Documentation
Testing
@code_lowered and
@code_typed)