fix: handle flipY: false correctly in copyExternalImageToTexture#337
Open
branikclimbs wants to merge 1 commit intowcandillon:mainfrom
Open
fix: handle flipY: false correctly in copyExternalImageToTexture#337branikclimbs wants to merge 1 commit intowcandillon:mainfrom
flipY: false correctly in copyExternalImageToTexture#337branikclimbs wants to merge 1 commit intowcandillon:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #336
Summary
std::optional<bool>check inGPUQueue::copyExternalImageToTexturethat treatedflipY: falsethe same asflipY: trueif (source->flipY)→if (source->flipY.value_or(false))Context
Three.js r173 (mrdoob/three.js#30260) started passing
flipYexplicitly tocopyExternalImageToTexture. This exposed the bug — GLTF textures passflipY: false, which engaged the optional and triggered the flip path, producing visually corrupted textures.