Skip to content

feat: integrate proxy support for REST/gRPC/OIDC and add new OIDC authentication grant#539

Open
fer-marino wants to merge 56 commits intoweaviate:mainfrom
fer-marino:feature/system-props
Open

feat: integrate proxy support for REST/gRPC/OIDC and add new OIDC authentication grant#539
fer-marino wants to merge 56 commits intoweaviate:mainfrom
fer-marino:feature/system-props

Conversation

@fer-marino
Copy link

@fer-marino fer-marino commented Feb 23, 2026

This PR introduces comprehensive proxy support for both REST and gRPC communications, as well as for OIDC authentication.

Changes

Features

  • Proxy Support: Introduced a new Proxy record to hold proxy configuration (host, port, scheme, and optional credentials).
  • Global Configuration: Added a proxy(Proxy) method to the Config builder, allowing users to configure a proxy globally for all client operations.
  • New Authentication Method: Added resourceOwnerPasswordCredentials to the Authentication interface, supporting the Resource Owner Password Credentials authorization grant.
  • REST Transport Integration: Updated DefaultRestTransport to use the configured proxy with Apache HttpClient 5.
  • gRPC Transport Integration: Added proxy support for gRPC communication in DefaultGrpcTransport.
  • OIDC Proxy Support: Integrated proxy support into NimbusTokenProvider and OidcUtils, ensuring that OIDC metadata and token requests (fetching and refreshing) correctly respect the proxy settings.

Refactoring

  • Improved OIDC Metadata Handling: Refactored OIDC metadata fetching to be more robust and better integrated with the transport layer.

Testing

  • New Unit Tests: Added ProxyTest and updated AuthenticationTest to verify proxy integration for both REST requests and OIDC authentication flows (including Resource Owner Password grant).

Verification

  • Ran existing and new unit tests to confirm that proxy settings are correctly passed to the underlying transports.
  • Verified that OIDC token fetching works through a proxy by mocking the OIDC server responses.
  • Confirmed that gRPC communication respects the proxy configuration.

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@weaviate-git-bot
Copy link

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Forum?

@bevzzz
Copy link
Collaborator

bevzzz commented Feb 23, 2026

Nice addition, thank you @fer-marino

fer-marino and others added 4 commits March 9, 2026 14:49
Co-authored-by: dyma solovei <53943884+bevzzz@users.noreply.github.com>
…java

Co-authored-by: dyma solovei <53943884+bevzzz@users.noreply.github.com>
…usTokenProvider.java

Co-authored-by: dyma solovei <53943884+bevzzz@users.noreply.github.com>
@fer-marino
Copy link
Author

added some more test units, including one for the proxy. I've also modified the pom, as in my setup the lombok annotation processor was not getting invoked during unit tests execution.

@bevzzz
Copy link
Collaborator

bevzzz commented Mar 9, 2026

added some more test units, including one for the proxy

Thank you 👍

@fer-marino
Copy link
Author

pushed another commit with your suggestions

@bevzzz
Copy link
Collaborator

bevzzz commented Mar 10, 2026

@fer-marino please update your branch to the latest main state, there're some changes that should fix the failing tests in the pipeline.

+3 pending comments ⬆️

Fernando Marino and others added 13 commits March 10, 2026 13:51
Co-authored-by: dyma solovei <53943884+bevzzz@users.noreply.github.com>
….java

Co-authored-by: dyma solovei <53943884+bevzzz@users.noreply.github.com>
…usTokenProvider.java

Co-authored-by: dyma solovei <53943884+bevzzz@users.noreply.github.com>
Co-authored-by: dyma solovei <53943884+bevzzz@users.noreply.github.com>
…java

Co-authored-by: dyma solovei <53943884+bevzzz@users.noreply.github.com>
…usTokenProvider.java

Co-authored-by: dyma solovei <53943884+bevzzz@users.noreply.github.com>
@fer-marino fer-marino requested a review from a team as a code owner March 10, 2026 13:04
@fer-marino
Copy link
Author

rebased

@fer-marino fer-marino changed the title use system props when creating the RestTransport feat: integrate proxy support for REST/gRPC/OIDC and add new OIDC authentication grant Mar 10, 2026
…remove redundant version-based permission conditions
@bevzzz
Copy link
Collaborator

bevzzz commented Mar 11, 2026

@fer-marino looks like the commit hashes got changed in the rebase and the history/diff in this PR now includes changes already present in the main branch. Could you please squash your changes in to a single commit and force-push the branch?

Something like:

git reset --soft origin/main
git commit -m "feat: add proxy support and ROPC authorization grant"
git push --force-with-lease

It'll make it easier for me to wrap up the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants