Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds build, HAL, linker, documentation, and Lauterbach scripting needed to bring up and program wolfBoot on the NXP QorIQ T1040 RDB.
Changes:
- Introduces a new
nxp_t1040target (build flags, example config, link scripts, HAL wrapper). - Adds T1040-specific test application and updates test-app build logic.
- Adds Lauterbach
.cmmscripts and target documentation for flashing/debugging.
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/scripts/nxp_t1040/t1024_flash.cmm | Adds a TRACE32 NOR flashing script intended for T1040. |
| tools/scripts/nxp_t1040/t1024_debug.cmm | Adds a TRACE32 debug setup script (CPU/MMU/symbols/breakpoints). |
| test-app/app_nxp_t1040.c | Adds a simple UART “heartbeat” test app for T1040. |
| test-app/Makefile | Enables PPC64 build settings for nxp_t1040. |
| hal/nxp_t1040_stage1.ld | Adds stage1 linker script for T1040 boot-from-NOR layout. |
| hal/nxp_t1040.ld | Adds main linker script for T1040 RAM-loaded image. |
| hal/nxp_t1040.c | Adds T1040 HAL wrapper to shared T10xx implementation. |
| hal/nxp_t1024.c | Replaces large T1024-specific HAL with a shared T10xx wrapper include. |
| hal/nxp_ppc.h | Adds TARGET_nxp_t1040 platform definitions. |
| docs/Targets.md | Documents T1040 target, flash map, and build steps. |
| config/examples/nxp-t1040.config | Adds example configuration for T1040 memory map / partitions. |
| arch.mk | Adds compiler/linker flags and object selection for nxp_t1040. |
| Makefile | Selects factory_wstage1.bin as main target for nxp_t1040. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 16 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.