f-311:C_WrapKey does not check CKA_EXTRACTABLE on the key being wrapped#165
Open
miyazakh wants to merge 1 commit intowolfSSL:masterfrom
Open
f-311:C_WrapKey does not check CKA_EXTRACTABLE on the key being wrapped#165miyazakh wants to merge 1 commit intowolfSSL:masterfrom
CKA_EXTRACTABLE on the key being wrapped#165miyazakh wants to merge 1 commit intowolfSSL:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C_WrapKey doesn't check
CKA_EXTRACTABLEon the key being wrapped. NeitherWP11_Generic_SerializeKeynorWP11_Rsa_SerializeKeyPTPKCS8check the extractable flag before serializing key material. Per the PKCS#11 specification,C_Wrapkeyhas to returnCKR_KEY_UNEXTRACTABLEwhen attempting to wrap a key withCKA_EXTRACTABLE=CK_FALSE. This allows an attacker with a valid session to export any key material through wrapping, even keys explicitly marked as non-extractable, defeating the fundamental key protection model.Fix the issue and add regression test.
Fix the unit test which expected to be wrapping the key, but it didn't set
CKA_ETRACTABLEtoCK_TRUE