feat: fga adding base types and module registraiton by swaroopAkkineniWorkos · Pull Request #556 · workos/workos-python

swaroopAkkineniWorkos · 2026-02-19T19:02:30Z

Description

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

linear · 2026-02-19T19:02:34Z

ENT-5224 Update Python sdk for fga

swaroopAkkineniWorkos · 2026-02-21T20:39:46Z

@greptile review

greptile-apps

_{19 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-21T20:43:34Z

src/workos/types/authorization/organization_membership.py

+from workos.types.workos_model import WorkOSModel
+from workos.typing.literals import LiteralOrUntyped
+
+OrganizationMembershipStatus = Literal["active", "inactive", "pending"]


Duplicated OrganizationMembershipStatus literal

This exact same Literal["active", "inactive", "pending"] type alias is already defined in src/workos/types/user_management/organization_membership.py:7. Consider importing from a shared location or re-exporting from one module to the other to avoid the definitions drifting apart over time.

Just pushed up a change where I moved "OrganizationMembershipStatus" to it's own file to be imported

greptile-apps

_{17 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

swaroopAkkineniWorkos · 2026-02-24T20:49:03Z

Change branch name before merging

src/workos/utils/_base_http_client.py

src/workos/authorization.py

csrbarber · 2026-02-24T21:28:50Z

src/workos/authorization.py

+        if cascade_delete is not None:
+            await self._http_client.delete_with_body(
+                f"{AUTHORIZATION_RESOURCES_PATH}/{resource_id}",
+                json={"cascade_delete": cascade_delete},


This adds cascade_delete to the body, but I believe it should be passed as a query param instead. Which is what delete_resource_by_external_id does here

updated to be a param

csrbarber · 2026-02-24T21:37:33Z

src/workos/authorization.py

+        if description is not None:
+            json["description"] = description


Does description here need the same treatment as in update_resource?

csrbarber · 2026-02-24T21:41:47Z

tests/test_authorization_resource_crud.py

+
+    # --- create_resource ---
+
+    def test_create_resource_required_fields_only(


Should we update this test since parent isn't a required field?

updated and added a test

csrbarber · 2026-02-24T21:58:24Z

src/workos/types/authorization/organization_membership.py

+    id: str
+    user_id: str
+    organization_id: str
+    organization_name: str


It looks like we don't include organization_name in the responses where this gets used. For instance listOrganizationMembershipsForResource calls serializeBase, which doesn't include organization_name.

swaroopAkkineniWorkos · 2026-03-02T17:15:11Z

@greptile plz re-review

greptile-apps · 2026-03-02T17:24:33Z

Greptile Summary

This PR adds foundational types and CRUD operations for Fine-Grained Authorization (FGA) resources to the WorkOS Python SDK. The implementation introduces resource management capabilities with support for both ID-based and external-ID-based operations.

Key Changes:

Added complete CRUD operations for authorization resources (get_resource, create_resource, update_resource, delete_resource, list_resources)
Implemented external ID-based resource operations for more flexible resource identification
Added check method for permission-based access control
Enhanced HTTP client to support exclude_none parameter for precise control over null value handling in API requests
Introduced delete_with_body method (though not used in this PR, likely for future functionality)
Refactored OrganizationMembership to extract BaseOrganizationMembership for code reuse across modules
Comprehensive test coverage for all new functionality

Implementation Quality:

Uses the UNSET pattern correctly to distinguish between "don't update field" vs "set field to null"
Proper handling of optional parent resources (by ID or external ID)
Well-tested with both sync and async implementations
Type-safe with Pydantic models and proper TypedDict usage

Minor Issue:

TODO comment on line 56 of authorization.py should be resolved

Confidence Score: 4/5

This PR is safe to merge with minimal risk
The implementation is well-structured with comprehensive test coverage for all new functionality. The code follows established patterns in the codebase and properly handles edge cases. The only issue is a minor TODO comment that should be addressed.
Pay attention to src/workos/authorization.py due to the TODO comment on line 56

Important Files Changed

Filename	Overview
src/workos/authorization.py	Adds resource CRUD operations and access check functionality; contains TODO comment on line 56
src/workos/utils/http_client.py	Adds `exclude_none` parameter and `delete_with_body` method for enhanced HTTP request handling
src/workos/utils/_base_http_client.py	Adds `force_include_body` and `exclude_none` parameters to support DELETE with body and optional null values
src/workos/types/authorization/authorization_resource.py	Defines `AuthorizationResource` model with proper typing and optional fields

_{Last reviewed commit: 954bb37}

greptile-apps · 2026-03-02T17:24:36Z

src/workos/authorization.py

+# TODO RENAME
+ResourcesListResource = WorkOSListResource[
+    AuthorizationResource, ResourceListFilters, ListMetadata
+]


TODO comment needs resolution

Either rename ResourcesListResource to something more descriptive (like AuthorizationResourceList) or remove the TODO if the current name is acceptable.

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

updated and changed name

atainter

Looks good to me. Should probably get a review from python code owners as well

…ound

…rce, list_memberships_for_resource_by_external_id (#571)

adding base types and module registraiton

ab35617

swaroopAkkineniWorkos added 3 commits February 19, 2026 11:00

moar

5f6892d

lol

0bc40fb

lol

526eb7d

swaroopAkkineniWorkos changed the title ~~adding base types and module registraiton~~ FGA_BASE: adding base types and module registraiton Feb 20, 2026

greptile-apps bot reviewed Feb 21, 2026

View reviewed changes

swaroopAkkineniWorkos added 3 commits February 23, 2026 04:38

nits for re-dupe OrganizationMembershipStatus

13dad51

Format

ff239c7

adding AUTHORIZATION_RESOURCES_PATH to base

a5823c6

swaroopAkkineniWorkos marked this pull request as ready for review February 23, 2026 17:52

swaroopAkkineniWorkos requested a review from a team as a code owner February 23, 2026 17:52

swaroopAkkineniWorkos requested review from atainter, csrbarber and tribble February 23, 2026 17:52

greptile-apps bot reviewed Feb 23, 2026

View reviewed changes

FGA_1: create/delete/get/update resource (#563)

8dd434f

FGA_2: listResources(), get/update/delete resource_by_external_id (#569)

fe59018

csrbarber reviewed Feb 24, 2026

View reviewed changes

src/workos/utils/_base_http_client.py Show resolved Hide resolved

FGA_3: check() (#568)

a50f5d5

csrbarber reviewed Feb 24, 2026

View reviewed changes

src/workos/authorization.py Outdated Show resolved Hide resolved

csrbarber reviewed Feb 24, 2026

View reviewed changes

swaroopAkkineniWorkos added 3 commits February 24, 2026 12:52

remove organization_name for list

3eca552

casade

fa170f0

lol

035f1c3

swaroopAkkineniWorkos added 18 commits March 2, 2026 03:32

merge conflcits

ba59cf6

refactor authorization resource

6b8ca59

Test updates

f04c33e

get_resource

778aa67

create

dcd8bda

Get changes

070c2ca

delete

58564df

list

a71ebc6

get_resource_by_external_id

2199f79

update_resource_by_external_id

d3e3c79

delete_resource_by_external_id

3127241

check

a554548

Cleaner tests

d7c4f7e

nits

5211752

lint

a6d1db9

type fix

17c754c

type fix

7c96c59

type fix

954bb37

workos deleted a comment from greptile-apps bot Mar 2, 2026

greptile-apps bot reviewed Mar 2, 2026

View reviewed changes

swaroopAkkineniWorkos added 2 commits March 2, 2026 07:33

update

0e5eaab

final nit

87eb732

atainter approved these changes Mar 3, 2026

View reviewed changes

csrbarber approved these changes Mar 3, 2026

View reviewed changes

FGA_4: list/assign/remove role, remove roleAssginment (#570)

01e567d

swaroopAkkineniWorkos changed the title ~~FGA_BASE: adding base types and module registraiton~~ feat: fga adding base types and module registraiton Mar 4, 2026

swaroopAkkineniWorkos added 2 commits March 4, 2026 05:31

Merge branch 'main' into ENT-5224-python-sdk-for-fga-worktree-fuck-ar…

0ef43e8

…ound

feat: FGA_5 list_resources_for_membership, list_memberships_for_resou…

08f1c84

…rce, list_memberships_for_resource_by_external_id (#571)

		if description is not None:
		json["description"] = description


		# --- create_resource ---

		def test_create_resource_required_fields_only(

Conversation

swaroopAkkineniWorkos commented Feb 19, 2026

Description

Documentation

Uh oh!

linear bot commented Feb 19, 2026

Uh oh!

swaroopAkkineniWorkos commented Feb 21, 2026

Uh oh!

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

swaroopAkkineniWorkos commented Feb 24, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

swaroopAkkineniWorkos commented Mar 2, 2026

Uh oh!

greptile-apps bot commented Mar 2, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

greptile-apps bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

atainter left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

greptile-apps bot left a comment •

edited

Loading