Fix --host-command sending truncated payload on invalid byte#269
Closed
Copilot wants to merge 2 commits intohost-commandfrom
Closed
Fix --host-command sending truncated payload on invalid byte#269Copilot wants to merge 2 commits intohost-commandfrom
Copilot wants to merge 2 commits intohost-commandfrom
Conversation
Co-authored-by: JohnAZoidberg <5307138+JohnAZoidberg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on adding --host-command for raw EC host commands
Fix --host-command sending truncated payload on invalid byte
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--host-commandencountered an invalid payload byte, itbreaked the parse loop but still returnedSome((cmd_id, version, data))— silently sending a truncated command instead of failing.Changes
framework_lib/src/commandline/uefi.rs: Introduce aparse_errorflag in the byte-parsing loop. On an invalid byte, set the flag and break; after the loop, returnNoneifparse_erroris set, making any malformed payload a hard parse failure.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.