Skip to content

Fix --host-command sending truncated payload on invalid byte #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix --host-command sending truncated payload on invalid byte #269

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
556670c
Initial plan
Copilot Mar 2, 2026
50a3c8f
Fix --host-command to return None on invalid payload byte
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion framework_lib/src/commandline/uefi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,7 @@ pub fn parse(args: &[String]) -> Cli {
let version = parse_hex_or_dec_u8(&args[i + 2]);
if let (Some(cmd_id), Some(version)) = (cmd_id, version) {
let mut data = Vec::new();
let mut parse_error = false;
for j in (i + 3)..args.len() {
if args[j].starts_with('-') {
break;
Expand All @@ -722,10 +723,15 @@ pub fn parse(args: &[String]) -> Cli {
data.push(byte);
} else {
println!("Invalid data byte for --host-command: '{}'", args[j]);
parse_error = true;
break;
}
}
Some((cmd_id, version, data))
if parse_error {
None
} else {
Some((cmd_id, version, data))
}
} else {
println!("Invalid values for --host-command. Usage: --host-command <CMD_ID> <VERSION> [DATA...]");
None
Expand Down