chore: regenerate by mstruebing · Pull Request #2770 · kubernetes-client/javascript

mstruebing · 2026-02-14T14:22:53Z

This regenerates the with the new openapi generator after the changes from #2738

The code needs to be adjusted the generator now works wit undici.
Help would be appreciated, I've tried it two times but always went into deep rabbit holes.

k8s-ci-robot · 2026-02-14T14:22:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mstruebing]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

davidgamero · 2026-02-14T15:50:21Z

i started on this too, im working on the nock testing bit as undici fetch uses mocks instead

socks proxy was a rabbithole too i havent found a solution for that yet

Rezrazi · 2026-02-18T19:45:49Z

@mstruebing @davidgamero I tried to give it a go, however many apis use "fetch" directly, instead of using the same "configuration" pattern in other regular APIs.

Would you prefer if the APIs are to be rewritten to match the same pattern? in the spirit of my previous PR updating watch_api?

I think if all APIs are aligned, it would be easier to update to undici, but it will most definitely be a breaking change

Rezrazi · 2026-02-18T20:01:41Z

these apis currently use fetch() directly

src/health.ts
src/log.ts
src/metrics.ts
src/watch.ts

brendandburns · 2026-03-12T19:57:52Z

@copilot please fix this PR

Copilot · 2026-03-12T19:58:00Z

@brendandburns I've opened a new pull request, #2794, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

…gent Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

fix: migrate API client HTTP transport from node-fetch to undici

brendandburns · 2026-03-17T23:33:52Z

I tried a copilot fix for this which is now applied, it modifies a bunch of the tests, I did some manual verification, but would love a second pair of eyes.

brendandburns · 2026-03-17T23:34:56Z

@copilot please fix tests, looks like File is not defined? Maybe this is a nodejs 18 thing?

Copilot · 2026-03-17T23:35:03Z

@brendandburns I've opened a new pull request, #2797, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

…gain [WIP] [#2738] Regenerate OpenAPI generator

brendandburns · 2026-03-17T23:48:35Z

@copilot please fix the remaining 3 failing tests.

Copilot · 2026-03-17T23:48:42Z

@brendandburns I've opened a new pull request, #2798, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

…nother-one fix: correct incorrectly nested tests in object_test.ts

brendandburns · 2026-03-17T23:59:45Z

@mstruebing @davidgamero All tests now appear to be passing.

If you two could take a look and make sure that we didn't regress our test coverage in these changes that'd be great.

I did my own scan and it seems to be ok, but it never hurts to have multiple eyes on the subject.

@copilot please do one last scan to make sure that our unit test coverage hasn't regressed because of this PR, if it has regressed, please add additional coverage to bring it back up to standard.

Copilot · 2026-03-17T23:59:53Z

@brendandburns I've opened a new pull request, #2799, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

…test data Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

cjihrig · 2026-03-18T00:56:19Z

src/azure_auth_test.ts

+        strictEqual(dispatcher instanceof UndiciAgent, true);
+        strictEqual(
+            dispatcher[
+                Object.getOwnPropertySymbols(dispatcher).find((s) => s.toString() === 'Symbol(options)')!


Non-blocking nit: this approach is fragile and is basically reaching into undici internals. I don't have a better suggestion though.

cjihrig · 2026-03-18T00:56:59Z

src/azure_auth_test.ts

+        // When skipTLSVerify is not set, no custom dispatcher is needed - undici validates certs by default
+        strictEqual(requestContext.getDispatcher(), undefined);


This doesn't seem all that helpful for validating anything.

cjihrig · 2026-03-18T01:00:19Z

src/config.ts

+        if (cluster && cluster.proxyUrl) {
+            if (cluster.proxyUrl.startsWith('socks')) {
+                throw new Error(
+                    'SOCKS proxy is not supported with the undici HTTP client. ' +


Does this mean we are dropping support for this feature?

looks like this was just merged in the last 2weeks, nodejs/undici#4385
on undici 7.23.0 so there's a path to bringing it back without additional packages

I've updated undici and removed the throw and added a test - with the fragile approach for now.

cjihrig · 2026-03-18T01:01:24Z

src/gcp_auth_test.ts

+        strictEqual(dispatcher instanceof UndiciAgent, true);
+        strictEqual(
+            dispatcher[
+                Object.getOwnPropertySymbols(dispatcher).find((s) => s.toString() === 'Symbol(options)')!


Same comment about this being fragile. I see it happens a few more times so I'll stop pointing it out.

cjihrig · 2026-03-18T01:04:48Z

src/integration_test.ts

+                await mockAgent.close();
+                setGlobalDispatcher(originalDispatcher);


These should probably be in a t.after() hook around line 39.

cjihrig · 2026-03-18T01:07:49Z

src/metrics.ts

            throw new ApiException<undefined | V1Status>(
                500,
-                `Error occurred in metrics request: ${e.message}`,
+                `Error occurred in metrics request: ${e.message}${e.cause ? ': ' + e.cause.message : ''}`,


I don't know if it makes sense in this case, but it seems like it would be more idiomatic to attach e as the cause of this error being thrown.

cjihrig · 2026-03-18T01:09:40Z

package.json

@@ -70,6 +70,7 @@
        "socks-proxy-agent": "^8.0.4",


Are any deps now unused? I was thinking along the lines of node-fetch, socks-proxy-agent, or nock? I didn't check to see if they are still used anywhere.

cjihrig · 2026-03-18T01:10:48Z

src/top_test.ts

+            } finally {
+                await mockAgent.close();
+                setGlobalDispatcher(originalDispatcher);
+            }


Same comment on all of these finally blocks about using a t.after() hook.

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

…et-again fix: restore unit test coverage for proxy agent paths in config.ts

brendandburns · 2026-03-18T22:26:49Z

@copilot can you address the comments wrt to the finally block?

@cjihrig I think that socks proxy support is still there, since there is now a unit test for the SoxyProxyAgent showing up but if we get to the point of creating an undici dispatcher, which is HTTP, and the proxy is SOCKS, it will error out. This should really never happen. (at least that's my reading of the code)

Copilot · 2026-03-18T22:26:57Z

@brendandburns I've opened a new pull request, #2800, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

davidgamero · 2026-03-19T03:49:52Z

src/config_test.ts

+            strictEqual(
+                (dispatcher as any)[
+                    Object.getOwnPropertySymbols(dispatcher!).find((s) => s.toString() === 'Symbol(options)')!
+                ].connect.servername,


i echo the previous comments on private state extraction of symbols @cjihrig
as many of these tests are essentially validating args to the UndiciAgent | UndiciProxyAgent constructors,

proposal to extract a createDispatcherOptions method from createDispatcher that shares a parameter signature ex:

private createDispatcherOptions( cluster: Cluster | null, agentOptions: https.AgentOptions ): UndiciAgentOptions | UndiciProxyAgentOptions

we can test that method directly, and the createDispatcher function serves to pass those options to constructors exclusively.
this would remove the need for much of the fragile introspection

davidgamero · 2026-03-19T03:58:53Z

@copilot try out the idea to extract a createDispatcherOptions method in a PR and note if it can effectively reduce reliance on symbol internals by testing the options generation instead of the objects post-constructor invocation:

proposal to extract a createDispatcherOptions method from createDispatcher that shares a parameter signature ex:

private createDispatcherOptions(
  cluster: Cluster | null,
  agentOptions: https.AgentOptions
): UndiciAgentOptions | UndiciProxyAgentOptions

we can test that method directly, and the createDispatcher function serves to pass those options to >constructors exclusively.

…ptions

…ne-more-time refactor: replace try/finally with t.after() hooks in tests

davidgamero · 2026-03-19T19:56:46Z

made a PR into this branch for the options extraction here #2801

…arrowing

…her-testing extract dispatcher options construction method

brendandburns · 2026-03-19T21:48:17Z

@copilot please fix tests again, looks like the undici version got moved to version 7 again and it should be version 6

Copilot · 2026-03-19T21:48:26Z

@brendandburns I've opened a new pull request, #2802, to work on those changes. Once the pull request is ready, I'll request review from you.

chore: regenerate

faac313

k8s-ci-robot requested review from brendandburns and davidgamero February 14, 2026 14:22

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2026

mstruebing mentioned this pull request Feb 14, 2026

feat(api): Add watch_api.ts with async iterator support and Configuration pattern #2738

Open

Initial plan

25b153d

Copilot AI mentioned this pull request Mar 12, 2026

fix: migrate API client HTTP transport from node-fetch to undici #2794

Merged

Copilot AI and others added 4 commits March 12, 2026 20:49

fix: migrate from node-fetch agent to undici dispatcher for API client

c96c4be

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

fix: restore test verifications and migrate remaining files to undici

e0fd44b

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

fix: restore test verifications and migrate all tests to undici MockA…

2e86fcf

…gent Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

Merge pull request #2794 from kubernetes-client/copilot/sub-pr-2770

0211177

fix: migrate API client HTTP transport from node-fetch to undici

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2026

Initial plan

762cce9

Copilot AI mentioned this pull request Mar 17, 2026

[WIP] [#2738] Regenerate OpenAPI generator #2797

Merged

Copilot AI and others added 2 commits March 17, 2026 23:43

fix: downgrade undici to v6.x to fix File is not defined on Node.js 18

9726838

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

Merge pull request #2797 from kubernetes-client/copilot/sub-pr-2770-a…

53db566

…gain [WIP] [#2738] Regenerate OpenAPI generator

Initial plan

77fe123

Copilot AI and others added 2 commits March 17, 2026 23:52

fix: move 3 incorrectly nested tests to proper scope in object_test.ts

4ac029a

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

Merge pull request #2798 from kubernetes-client/copilot/sub-pr-2770-a…

596aedf

…nother-one fix: correct incorrectly nested tests in object_test.ts

Initial plan

c9bcff5

Copilot AI mentioned this pull request Mar 17, 2026

fix: restore unit test coverage for proxy agent paths in config.ts #2799

Merged

Copilot AI and others added 2 commits March 18, 2026 00:06

Initial plan

f75ff67

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

fix: restore coverage for proxy agent paths and add missing contextG …

ec0a01f

…test data Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

cjihrig reviewed Mar 18, 2026

View reviewed changes

Copilot AI and others added 2 commits March 18, 2026 14:51

revert: restore settings file to original state

b15d9bd

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

Merge pull request #2799 from kubernetes-client/copilot/sub-pr-2770-y…

61b081f

…et-again fix: restore unit test coverage for proxy agent paths in config.ts

Initial plan

75b55aa

Copilot AI mentioned this pull request Mar 18, 2026

refactor: replace try/finally with t.after() hooks in tests #2800

Merged

refactor: use t.after() hooks instead of try/finally in tests

f488395

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

davidgamero reviewed Mar 19, 2026

View reviewed changes

mstruebing and others added 5 commits March 19, 2026 08:36

support socks proxy

fb174cc

refactor to createDispatcherOptions

bd668f6

fix: remove unused DispatcherOptions import from config_test

c0c3221

refactor: use tls.ConnectionOptions and rename connectOptions to tlsO…

ff76b1a

…ptions

Merge pull request #2800 from kubernetes-client/copilot/sub-pr-2770-o…

7d2213d

…ne-more-time refactor: replace try/finally with t.after() hooks in tests

davidgamero and others added 2 commits March 19, 2026 17:04

refactor: remove redundant if blocks, rely on strictEqual assertion n…

670f178

…arrowing

Merge pull request #2801 from davidgamero/davidgamero/improve-dispatc…

09c8201

…her-testing extract dispatcher options construction method

Copilot AI mentioned this pull request Mar 19, 2026

fix: downgrade undici to v6 and add SOCKS proxy support for undici dispatcher path #2802

Draft

		// When skipTLSVerify is not set, no custom dispatcher is needed - undici validates certs by default
		strictEqual(requestContext.getDispatcher(), undefined);

		await mockAgent.close();
		setGlobalDispatcher(originalDispatcher);

Conversation

mstruebing commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 14, 2026

Uh oh!

davidgamero commented Feb 14, 2026

Uh oh!

Rezrazi commented Feb 18, 2026

Uh oh!

Rezrazi commented Feb 18, 2026

Uh oh!

brendandburns commented Mar 12, 2026

Uh oh!

Copilot AI commented Mar 12, 2026

Uh oh!

brendandburns commented Mar 17, 2026

Uh oh!

brendandburns commented Mar 17, 2026

Uh oh!

Copilot AI commented Mar 17, 2026

Uh oh!

brendandburns commented Mar 17, 2026

Uh oh!

Copilot AI commented Mar 17, 2026

Uh oh!

brendandburns commented Mar 17, 2026

Uh oh!

Copilot AI commented Mar 17, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brendandburns commented Mar 18, 2026

Uh oh!

Copilot AI commented Mar 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidgamero commented Mar 19, 2026

Uh oh!

davidgamero commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brendandburns commented Mar 19, 2026

Uh oh!

Copilot AI commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mstruebing commented Feb 14, 2026 •

edited

Loading

davidgamero commented Mar 19, 2026 •

edited

Loading