refactor: replace try/finally with t.after() hooks in tests#2800
Merged
brendandburns merged 2 commits intomax-regen-genfrom Mar 19, 2026
Merged
refactor: replace try/finally with t.after() hooks in tests#2800brendandburns merged 2 commits intomax-regen-genfrom
brendandburns merged 2 commits intomax-regen-genfrom
Conversation
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Copilot
AI
changed the title
[WIP] [#2738] Adjust code for new OpenAPI generator
refactor: replace try/finally with t.after() hooks in tests
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test cleanup for undici
MockAgent(close + restore global dispatcher) was done intry/finallyblocks. Usingt.after()is the idiomatic pattern for the Node.js built-in test runner and keeps cleanup co-located with setup rather than buried at the end of test logic.Changes
src/integration_test.ts: Registert.after()hook immediately aftersetGlobalDispatcher(mockAgent)to close the agent and restore the original dispatchersrc/top_test.ts: Same refactor across all 9 test cases — hook registered right aftersystemUnderTest()(which internally callssetGlobalDispatcher)Before
After
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.